[webkit-reviews] review granted: [Bug 65419] REGRESSION:culledInlineAbsoluteRects needs to translate a 0, 0 point to absolute coordinates so that the top left position is accurate. : [Attachment 102444] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Enrica Casucci <enrica at apple.com>'s request for
review:
Bug 65419: REGRESSION:culledInlineAbsoluteRects needs to translate a 0,0 point
to absolute coordinates so that the top left position is accurate.
https://bugs.webkit.org/show_bug.cgi?id=65419

Attachment 102444: Patch
https://bugs.webkit.org/attachment.cgi?id=102444&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=102444&action=review


> Source/WebCore/ChangeLog:8
> +	   This bug fixes a regression introduced in r83075.

I think you mean “this patch”

> Source/WebCore/testing/Internals.h:40
>  class Document;
>  class Element;
>  class Node;
> +class ClientRect;

Please keep these in ASCII order.

> Source/WebCore/testing/Internals.h:64
>  
> +    PassRefPtr<ClientRect> boundingBox(Element*, ExceptionCode&);

We need a newline before the private: label.

> Source/WebCore/testing/Internals.idl:41
> +	   ClientRect boundingBox(in Element element) raises(DOMException);

and maybe a newline above this

> LayoutTests/fast/inline/skipped-whitespace-boundingBox.html:10
> +    //var rect = document.getElementById('test').getBoundingClientRect();

No need for this comment :)