[webkit-reviews] review denied: [Bug 60403] [HTML5] Implement the selectionDirection property on input and textarea : [Attachment 102428] Fixed per comment
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jul 30 10:38:25 PDT 2011
Darin Adler <darin at apple.com> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 60403: [HTML5] Implement the selectionDirection property on input and
textarea
https://bugs.webkit.org/show_bug.cgi?id=60403
Attachment 102428: Fixed per comment
https://bugs.webkit.org/attachment.cgi?id=102428&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102428&action=review
> Source/WebCore/bindings/objc/PublicDOMInterfaces.h:632
> -- (void)setSelectionRange:(int)start end:(int)end
AVAILABLE_WEBKIT_VERSION_3_0_AND_LATER;
> +- (void)setSelectionRange:(int)start end:(int)end direction:(NSString
*)direction AVAILABLE_WEBKIT_VERSION_3_0_AND_LATER;
We can’t just change the Mac OS X public WebKit ObjC interface like this.
Getting rid of the old method will break existing applications using WebKit
that use it. They’ll get a method not found at runtime, and also won’t compile
against newer versions of the WebKit framework.
The point of this file is to catch WebKit developers when we are about to
create a binary incompatibility like this one.
To keep compatible, we’ll need setSelectionRange:end: to be implemented
somehow. I’m not sure what the best way of accomplishing that is, but one way
to do would be by adding optional-argument support to the Objective-C bindings
generator.
More information about the webkit-reviews
mailing list