[webkit-reviews] review denied: [Bug 65410] [Qt][WK2] Fix the build afer r92014 : [Attachment 102432] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 65410: [Qt][WK2] Fix the build afer r92014
https://bugs.webkit.org/show_bug.cgi?id=65410

Attachment 102432: Patch
https://bugs.webkit.org/attachment.cgi?id=102432&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102432&action=review


> Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:38
> +// Fix for the intrusive typedef in qwindowdefs.h until it has been fixed in
Qt.

Was a bug filed with Qt?

> Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:40
> +#define Region WebCore::Region
> +#endif

Adding "using WebCore::Region" inside the "namespace WebKit" clause should do
the trick as well.
In either case, I believe this problem is confined to X11, so let's #ifdef it.

#ifdef Q_WS_X11
using WebCore::Region;
#endif

seems a bit less intrusive than a new #define Region :)