[webkit-reviews] review granted: [Bug 65397] LayoutTests does not have a test for array speculation pathologies in the JavaScriptCore DFG JIT : [Attachment 102404] the patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 65397: LayoutTests does not have a test for array speculation pathologies
in the JavaScriptCore DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=65397

Attachment 102404: the patch
https://bugs.webkit.org/attachment.cgi?id=102404&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102404&action=review


> LayoutTests/fast/js/array-type-speculation-expected.txt:6
> +PASS result is "foo"

When possible, it's better to construct the test so that you can see what is
being tested in the test output. Just seeing "result" is not so great. One way
to do that is to make sure that the argument to shouldBe itself contains
arguments that make it clear which test is which.

But I know that with JavaScript testing it can be tricky to achieve that since
different ways of executing code exercise different code paths.