[webkit-reviews] review denied: [Bug 65389] DFG JIT verbose mode provides no details about predictions : [Attachment 102396] the patch (fix style, passes tests)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 29 14:35:27 PDT 2011


Gavin Barraclough <barraclough at apple.com> has denied Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 65389: DFG JIT verbose mode provides no details about predictions
https://bugs.webkit.org/show_bug.cgi?id=65389

Attachment 102396: the patch (fix style, passes tests)
https://bugs.webkit.org/attachment.cgi?id=102396&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Sorry to be a pain, but (1) this should be ndef NDEBUG only code.  If you find
this useful to have in a header to be able to use easily when debugging, then
I'd wrap in #ifndef NDEBUG, but you could also consider moving to the NDEBUG
section of the .cpp & marking as static.  Also, code on the same lines as
labels doesn't match the coding style, there should really be newlines in here.


More information about the webkit-reviews mailing list