[webkit-reviews] review granted: [Bug 64919] Remove remaining uses of CSSPrimitiveValue::computeLengthIntForLength() : [Attachment 101551] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 64919: Remove remaining uses of
CSSPrimitiveValue::computeLengthIntForLength()
https://bugs.webkit.org/show_bug.cgi?id=64919

Attachment 101551: Patch
https://bugs.webkit.org/attachment.cgi?id=101551&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101551&action=review


>>> Source/WebCore/css/CSSPrimitiveValue.cpp:279
>>> +	 // FIXME: Length.h no longer expects 28 bit integers, so these bounds
should be INT_MAX and INT_MIN
>> 
>> Why not fix that now?
> 
> Trying to avoid behavioral changes in this patch. Changing this will impact a
lot of properties, and potentially breaks a number of tests. This comment is
mostly about correcting the obsolete one above.

Probably the word is “could” rather than “should”.

Also would be best to have a period instead.

> Source/WebCore/platform/Length.h:97
> +    void setQuirk(bool quirk)
> +    {
> +	   m_quirk = quirk;
> +    }

I find the name “quirk” puzzling for a boolean data member. A boolean is not a
quirk. Not your fault, but really confusing.