[webkit-reviews] review granted: [Bug 65157] Simplify createCanonicalUUIDString implementation. : [Attachment 102298] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 28 15:43:06 PDT 2011


Adam Barth <abarth at webkit.org> has granted Justin Schuh <jschuh at chromium.org>'s
request for review:
Bug 65157: Simplify createCanonicalUUIDString implementation.
https://bugs.webkit.org/show_bug.cgi?id=65157

Attachment 102298: Patch
https://bugs.webkit.org/attachment.cgi?id=102298&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102298&action=review


I've added some folks to the CC line to make sure they see this patch go by.  I
can't think of any reason not to use the cryptographically random
implementation now that we have it.

> Source/WebCore/platform/UUID.cpp:45
> +    WTF::cryptographicallyRandomValues(reinterpret_cast<unsigned
char*>(randomData), sizeof(randomData));

The WTF:: part isn't needed.


More information about the webkit-reviews mailing list