[webkit-reviews] review granted: [Bug 65338] Remove LegacyDefaultOptionalArguments flag from HTML DOM IDL files : [Attachment 102300] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 28 15:24:15 PDT 2011


Adam Barth <abarth at webkit.org> has granted Mark Pilgrim
<pilgrim at chromium.org>'s request for review:
Bug 65338: Remove LegacyDefaultOptionalArguments flag from HTML DOM IDL files
https://bugs.webkit.org/show_bug.cgi?id=65338

Attachment 102300: Patch
https://bugs.webkit.org/attachment.cgi?id=102300&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102300&action=review


> Source/WebCore/html/HTMLAllCollection.idl:35
> -	   [Custom] Node item(in unsigned long index);
> +	   [Custom] Node item(in [Optional=CallWithDefaultValue] unsigned long
index);

It be worth adding a test that documents the behavior you tested from IE.


More information about the webkit-reviews mailing list