[webkit-reviews] review denied: [Bug 62175] [GTK] Implement monotonicallyIncreasingClock() : [Attachment 101659] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Devdatta
<pwjd73 at motorola.com>'s request for review:
Bug 62175: [GTK] Implement monotonicallyIncreasingClock()
https://bugs.webkit.org/show_bug.cgi?id=62175

Attachment 101659: Patch
https://bugs.webkit.org/attachment.cgi?id=101659&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101659&action=review


This looks sane to me.

> Source/JavaScriptCore/ChangeLog:9
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * wtf/CurrentTime.cpp:
> +	   (WTF::monotonicallyIncreasingTime):

Please fill in this ChangeLog, explaining how the existing implementation of
monotonicallyIncreasingTime can fail.

> Source/JavaScriptCore/wtf/CurrentTime.cpp:313
> +#elif PLATFORM(GTK)

I think it would be better to use #if ENABLE(GLIB_SUPPORT) here.