[webkit-reviews] review denied: [Bug 65322] Web Inspector: [REGRESSION] Inspected tab crashes if navigated with inspector open and there are watch expressions added. : [Attachment 102265] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 28 10:07:48 PDT 2011
Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 65322: Web Inspector: [REGRESSION] Inspected tab crashes if navigated with
inspector open and there are watch expressions added.
https://bugs.webkit.org/show_bug.cgi?id=65322
Attachment 102265: Patch
https://bugs.webkit.org/attachment.cgi?id=102265&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102265&action=review
> Source/WebCore/inspector/InspectorRuntimeAgent.cpp:66
> scriptState = getDefaultInspectedState();
Add you should do *errorString = "No frame with id is available.";
More information about the webkit-reviews
mailing list