[webkit-reviews] review granted: [Bug 65214] REGRESSION (Safari 5.1): JavaScript dialogs not usable with VoiceOver : [Attachment 102075] patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 65214: REGRESSION (Safari 5.1): JavaScript dialogs not usable with
VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=65214

Attachment 102075: patch
https://bugs.webkit.org/attachment.cgi?id=102075&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102075&action=review


>>> Source/WebKit2/Platform/CoreIPC/Connection.cpp:477
>>> +		 RunLoop::current()->runForDuration(1e10);
>> 
>> Won't this allow timers to fire, other messages to be processed, etc.? That
doesn't seem good.
> 
> It will, but that's also part of the idea, that Accessibility messages need
to be processed while waiting, otherwise accessibility clients will hang.
> 
> This is also what happens in WK1

Since we only ever call this with a big value, we could just use RunLoop::run()
here and not add runForDuration at all.

> Source/WebKit2/Platform/CoreIPC/Connection.h:67
> +    SpinRunLoopWhileWaitingForReplay = 1 << 0,

Typo, "Replay" instead of "Reply".