[webkit-reviews] review granted: [Bug 65185] Web Inspector: move location conversion functions to SourceFile. : [Attachment 102003] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 28 06:17:42 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 65185: Web Inspector: move location conversion functions to SourceFile.
https://bugs.webkit.org/show_bug.cgi?id=65185

Attachment 102003: Patch
https://bugs.webkit.org/attachment.cgi?id=102003&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102003&action=review


> Source/WebCore/inspector/front-end/SourceFile.js:55
> +    rawLocationToUILocation: function(lineNumber, columnNumber)

This should receive ScriptLocation (i.e. should not change).


More information about the webkit-reviews mailing list