[webkit-reviews] review denied: [Bug 65084] Build without video but fullscreen API is broken : [Attachment 102133] Proper fix with ChangeLog entry.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 28 03:51:02 PDT 2011


Philippe Normand <pnormand at igalia.com> has denied Denis Oliver Kropp
<dok at directfb.org>'s request for review:
Bug 65084: Build without video but fullscreen API is broken
https://bugs.webkit.org/show_bug.cgi?id=65084

Attachment 102133: Proper fix with ChangeLog entry.
https://bugs.webkit.org/attachment.cgi?id=102133&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102133&action=review


Almost there, thanks again for the patch!

> Source/WebCore/ChangeLog:3
> +	   This fixes build without video enabled. Bug 65084.

You need to have 2 lines, one for the bug description and the second line
containing the link to the bug.
prepare-ChangeLog --bug 65084 can be used too :)

> Source/WebCore/dom/EventDispatcher.cpp:9
> + * Copyright (C) 2011 Denis Oliver Kropp (dok at directfb.org)

According to our contributor policy only substantive code changes allow a
copyright update. This patch is quite small, so please remove this line.


More information about the webkit-reviews mailing list