[webkit-reviews] review denied: [Bug 65282] SMILTimeContainer using currentTime for animations : [Attachment 102183] use monotonicallyIncreasingTime rather than currentTime to update animations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 27 23:46:13 PDT 2011


Dirk Schulze <krit at webkit.org> has denied Scott Graham <scottmg at chromium.org>'s
request for review:
Bug 65282: SMILTimeContainer using currentTime for animations
https://bugs.webkit.org/show_bug.cgi?id=65282

Attachment 102183: use monotonicallyIncreasingTime rather than currentTime to
update animations
https://bugs.webkit.org/attachment.cgi?id=102183&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102183&action=review


The timing code is similar to the code in AnimationControler and AnimationBase.
But these classes use currentTime() as well. Shouldn't they be affected as well
some how?

r- because of the changelog.

> Source/WebCore/ChangeLog:9
> +	   SMILTimeContainer using currentTime for animations
> +	   https://bugs.webkit.org/show_bug.cgi?id=65282
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   No new tests, existing tests should play correctly when system clock

> +	   changed.

This needs a detailed description. What did you change? Why did you change it?
And it is not only important that do not break thinks: It is important how it
affects the behavior. You need tests to verify the new behavior, especially
what works now but didn't work before. Does your patch affect bug 31256 as
well?

> Source/WebCore/ChangeLog:11
> +	   * svg/animation/SMILTimeContainer.cpp:

Is SMILTimeContainer the only file in WebCore/svg that uses currentTime()?


More information about the webkit-reviews mailing list