[webkit-reviews] review denied: [Bug 64591] Use requestAnimationFrame callbacks to pump CSS animations : [Attachment 100998] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 27 18:37:13 PDT 2011


James Robinson <jamesr at chromium.org> has denied Alex Russell
<alex at dojotoolkit.org>'s request for review:
Bug 64591: Use requestAnimationFrame callbacks to pump CSS animations
https://bugs.webkit.org/show_bug.cgi?id=64591

Attachment 100998: Patch
https://bugs.webkit.org/attachment.cgi?id=100998&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100998&action=review


R- for naming nits and because I don't think this handles state transition
events (animationstart, animationend, animationiteration) correctly for
background tabs.  I believe that they should all still fire at the expected
times even when requestAnimationFrame isn't pumping at all.  To do this you
might need to set some explicit Timers in addition to the requestAnimationFrame
mechanism just for animation state transitions, and use requestAnimationFrame()
just for intermediate ticks.

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

You'll need to edit or remove this line


More information about the webkit-reviews mailing list