[webkit-reviews] review granted: [Bug 61017] [chromium] Turn on WTF_MULTIPLE_THREADS. : [Attachment 102204] CR feedback
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 27 17:00:55 PDT 2011
David Levin <levin at chromium.org> has granted Dmitry Lomov
<dslomov at google.com>'s request for review:
Bug 61017: [chromium] Turn on WTF_MULTIPLE_THREADS.
https://bugs.webkit.org/show_bug.cgi?id=61017
Attachment 102204: CR feedback
https://bugs.webkit.org/attachment.cgi?id=102204&action=review
------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102204&action=review
> Source/JavaScriptCore/wtf/FastMalloc.cpp:87
> +#endif // OS(WINDOWS)
You don't need to have these comments on the endif (and they are incorrect now
anyway).
> Source/JavaScriptCore/wtf/FastMalloc.cpp:113
> +static const LPVOID kTlsAllowValue = reinterpret_cast<LPVOID>(0); // must be
zero
Ideally make the comment look like a sentence.
"Must be zero."
More information about the webkit-reviews
mailing list