[webkit-reviews] review denied: [Bug 65286] V8 should correctly serialize Boolean, Number and String objects : [Attachment 102188] Changes to SerializedScriptValue + window-postmessage-clone.

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Luke Zarko
<lukezarko+bugzilla at gmail.com>'s request for review:
Bug 65286: V8 should correctly serialize Boolean, Number and String objects
https://bugs.webkit.org/show_bug.cgi?id=65286

Attachment 102188: Changes to SerializedScriptValue + window-postmessage-clone.
https://bugs.webkit.org/attachment.cgi?id=102188&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102188&action=review


Just a few minor things to clean up.

Thanks!

> LayoutTests/ChangeLog:14
> +	   ():

Either fix this by adding a function name or remove it.

> LayoutTests/fast/dom/Window/script-tests/postmessage-clone.js:224
> +	   'return [t1,t1,t2,f1,f1,f2]'

put spaces after commas

> LayoutTests/fast/dom/Window/window-postmessage-clone-expected.txt:6
> +FAIL: 'postMessage(var x = 0; try { eval("badref"); } catch(e) { x = e; }
x)' should throw but didn't

We should file a bug for these failures for SquirellFish.