[webkit-reviews] review denied: [Bug 64999] Remove operator new from JSCell : [Attachment 102193] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 27 15:24:00 PDT 2011
Oliver Hunt <oliver at apple.com> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 64999: Remove operator new from JSCell
https://bugs.webkit.org/show_bug.cgi?id=64999
Attachment 102193: Patch
https://bugs.webkit.org/attachment.cgi?id=102193&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102193&action=review
noticed a couple of additional abbreviations, correct those and this will be
finished :D
> Source/WebCore/bridge/c/CRuntimeObject.h:40
> + static CRuntimeObject* create(ExecState* exec, JSGlobalObject*
globalObject, PassRefPtr<CInstance> cinst)
normal name for 'cinst' would be instance
> Source/WebCore/bridge/objc/objc_runtime.h:95
> + static ObjcFallbackObjectImp* create(ExecState* exec, JSGlobalObject*
globalObject, ObjcInstance* inst, const Identifier& propertyName)
s/inst/instance
> Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.h:39
> + static ProxyRuntimeObject* create(JSC::ExecState* exec,
JSC::JSGlobalObject* globalObject, PassRefPtr<ProxyInstance> inst)
s/inst/instance
More information about the webkit-reviews
mailing list