[webkit-reviews] review requested: [Bug 65289] Disable GeolocationPositionCache on Apple ports : [Attachment 102191] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 27 15:13:31 PDT 2011
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked for review:
Bug 65289: Disable GeolocationPositionCache on Apple ports
https://bugs.webkit.org/show_bug.cgi?id=65289
Attachment 102191: Patch
https://bugs.webkit.org/attachment.cgi?id=102191&action=review
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).
* page/Geolocation.h: Update copyright. Include what we use.
(WebCore::Geolocation::PositionCacheWrapper): Add separate
implementation of PositionCacheWrapper that does not use
GeolocationPositionCache. Although GeolocationPositionCache
effectively does nothing until setDatabasePath() is called,
there's no need to compile the code if it's not being used.
* page/GeolocationPositionCache.cpp: Update macro guard.
---
3 files changed, 37 insertions(+), 4 deletions(-)
More information about the webkit-reviews
mailing list