[webkit-reviews] review denied: [Bug 61017] [chromium] Turn on WTF_MULTIPLE_THREADS. : [Attachment 102186] Enables WTF_MULTIPLE_THREADS in chromium port

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Dmitry Lomov <dslomov at google.com>'s
request for review:
Bug 61017: [chromium] Turn on WTF_MULTIPLE_THREADS.
https://bugs.webkit.org/show_bug.cgi?id=61017

Attachment 102186: Enables WTF_MULTIPLE_THREADS in chromium port
https://bugs.webkit.org/attachment.cgi?id=102186&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102186&action=review


> Source/JavaScriptCore/runtime/InitializeThreading.cpp:59
>      initializeDates();

Why not remove this too?

(and the String::Empty initialization).

> Source/JavaScriptCore/wtf/FastMalloc.cpp:74
> +// * allocation of a reasonably complicated sfEtruct

whoops

> Source/JavaScriptCore/wtf/FastMalloc.cpp:83
> +#if OS(WINDOWS)

and chromium?

I think this already compiles fine on Windows for Apple's port. (Ditto for the
OS(WINDOWS) below).