[webkit-reviews] review granted: [Bug 64999] Remove operator new from JSCell : [Attachment 102175] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 27 14:35:48 PDT 2011
Darin Adler <darin at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 64999: Remove operator new from JSCell
https://bugs.webkit.org/show_bug.cgi?id=64999
Attachment 102175: Patch
https://bugs.webkit.org/attachment.cgi?id=102175&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102175&action=review
> Source/JavaScriptCore/runtime/JSCell.h:127
> + // Note that the first two declarations of operator new have no
corresponding implementation and
> + // will cause link errors if you use them.
> void* operator new(size_t, ExecState*);
> void* operator new(size_t, JSGlobalData*);
Can these be made private so we are more likely to get compilation errors
rather than linking errors?
More information about the webkit-reviews
mailing list