[webkit-reviews] review denied: [Bug 65276] Add audionode.html and gain.html web audio layout tests : [Attachment 102170] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Chris Rogers <crogers at google.com>'s
request for review:
Bug 65276: Add audionode.html and gain.html web audio layout tests
https://bugs.webkit.org/show_bug.cgi?id=65276

Attachment 102170: Patch
https://bugs.webkit.org/attachment.cgi?id=102170&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102170&action=review


r- for the missing file.

> LayoutTests/webaudio/audionode.html:5
> +<!--
> +Performs basic tests on the AudioNode API.
> +-->

Nit: I would remove this since it's in the description() below.

> LayoutTests/webaudio/gain.html:12
> +<script type="text/javascript" src="resources/buffer-loader.js"></script>

Did you mean to include this file in the change?

> LayoutTests/webaudio/gain.html:22
> +var bufferDuration = 0.125;

Nit: I like to include the units in my variable names, e.g.,
bufferDurationSeconds.

> LayoutTests/webaudio/gain.html:63
> +    context = new webkitAudioContext(2, sampleRate * lengthInSeconds,
sampleRate);

Can you get someone familiar with the audio API to review this code?  I'm happy
to forward on their LGTM, but I don't really know the API.