[webkit-reviews] review granted: [Bug 64728] TiledDrawingArea: Use tile sets to paint old content while rendering for a new scale. : [Attachment 102118] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 64728: TiledDrawingArea: Use tile sets to paint old content while rendering
for a new scale.
https://bugs.webkit.org/show_bug.cgi?id=64728

Attachment 102118: Patch
https://bugs.webkit.org/attachment.cgi?id=102118&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102118&action=review


Looks good :)

> Source/WebKit2/UIProcess/TiledDrawingAreaProxy.cpp:396
> +    if (m_currentTileSet->contentsScale() == scale)

I doubt this is gonna be hit often :)

> Source/WebKit2/UIProcess/TiledDrawingAreaProxy.cpp:558
> +void TiledDrawingAreaProxy::removeAllTiles()

I don't think you need this method at all now. The tiles are cleared when the
old tileset is not needed anymore.