[webkit-reviews] review granted: [Bug 64689] [CSSRegions]Add basic RenderRegion support : [Attachment 101977] Patch 3

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Mihnea Ovidenie <mihnea at adobe.com>'s
request for review:
Bug 64689: [CSSRegions]Add basic RenderRegion support
https://bugs.webkit.org/show_bug.cgi?id=64689

Attachment 101977: Patch 3
https://bugs.webkit.org/attachment.cgi?id=101977&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101977&action=review


r=me

> Source/WebCore/rendering/RenderRegion.cpp:59
> +void RenderRegion::layout()
> +{
> +    ASSERT(needsLayout());
> +
> +    computeLogicalWidth();
> +    computeLogicalHeight();
> +
> +    setNeedsLayout(false);
> +}

This is interesting. I wonder if there should be an intrinsic size for regions
or not. I know this is being debated in the CSS WG. I suggested they have no
intrinsic size (and that is what you've done here), but I know others would
like them to maybe be more like iframes or objects (300x150 intrinsic size). I
guess for now we can just stick with 0x0.