[webkit-reviews] review denied: [Bug 65206] Replace SpecificityCalculator with TestConfiguration-driven logic. : [Attachment 102116] proposed GTK follow-up patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 27 09:02:16 PDT 2011


Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 65206: Replace SpecificityCalculator with TestConfiguration-driven logic.
https://bugs.webkit.org/show_bug.cgi?id=65206

Attachment 102116: proposed GTK follow-up patch
https://bugs.webkit.org/attachment.cgi?id=102116&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Your sense of smell is correct, the problem was that GTK actual bot configs
aren't matching anything in the provided all_test_configurations(). The right
fix is to teach all ports about all configs that are valid for them. I'll work
on this today.


More information about the webkit-reviews mailing list