[webkit-reviews] review denied: [Bug 19872] Inspector should support cd(window) in the command line : [Attachment 102136] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 27 06:07:11 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 19872: Inspector should support cd(window) in the command line
https://bugs.webkit.org/show_bug.cgi?id=19872

Attachment 102136: Patch
https://bugs.webkit.org/attachment.cgi?id=102136&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102136&action=review


> Source/WebCore/inspector/InspectorRuntimeAgent.cpp:66
> +	   if (!m_pageAgent) {

You should implement an abstract method fetching evaluation context instead.


More information about the webkit-reviews mailing list