[webkit-reviews] review requested: [Bug 64950] Fix _win32_check_running_pid on natvie windows : [Attachment 101595] Patch

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has asked  for review:
Bug 64950: Fix _win32_check_running_pid on natvie windows
https://bugs.webkit.org/show_bug.cgi?id=64950

Attachment 101595: Patch
https://bugs.webkit.org/attachment.cgi?id=101595&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101595&action=review


>> Tools/Scripts/webkitpy/common/system/executive.py:254
>> +			    ("th32AccessKey", ctypes.c_long)]
> 
> I don't see these new members mentioned here:
<http://msdn.microsoft.com/en-us/library/ms684839(v=vs.85).aspx>. Looks like
they only exist in the WinCE version of the struct. So I think we need to
detect whether we're on WinCE or not. Otherwise won't this break non-CE builds?


This is not related to WinCE!
I try the get the native windows python test all pass on my windows box (german
Windwos 7 Professional SP1 64bit).
I tried different versions of this patch, but this is the only one which
workded for me. :-/
Any idea why the function fails on my box without the two additional members?