[webkit-reviews] review requested: [Bug 56200] [GTK] WebKitIconDatabase doesn't keep icons cached : [Attachment 102130] New patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 27 05:15:07 PDT 2011


Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 56200: [GTK] WebKitIconDatabase doesn't keep icons cached
https://bugs.webkit.org/show_bug.cgi?id=56200

Attachment 102130: New patch
https://bugs.webkit.org/attachment.cgi?id=102130&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
It uses HashMap<String, Vector<OwnPtr<PendingIconRequest> >* > instead of
GList* for the pending icon requests as suggested by Martin. It also completes
the operation in an idle when the icon is already available in
webkit_icon_database_get_icon_pixbuf_async() to make sure the function is
always async, and it doesn't leak the icon when the operation is cancelled.


More information about the webkit-reviews mailing list