[webkit-reviews] review denied: [Bug 64950] Fix _win32_check_running_pid on natvie windows : [Attachment 101595] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 64950: Fix _win32_check_running_pid on natvie windows
https://bugs.webkit.org/show_bug.cgi?id=64950

Attachment 101595: Patch
https://bugs.webkit.org/attachment.cgi?id=101595&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101595&action=review


> Tools/Scripts/webkitpy/common/system/executive.py:254
> -			   ("szExeFile", ctypes.c_char * 260)]
> +			   ("szExeFile", ctypes.c_char * 260),
> +			   ("th32MemoryBase", ctypes.c_long),
> +			   ("th32AccessKey", ctypes.c_long)]

I don't see these new members mentioned here:
<http://msdn.microsoft.com/en-us/library/ms684839(v=vs.85).aspx>. Looks like
they only exist in the WinCE version of the struct. So I think we need to
detect whether we're on WinCE or not. Otherwise won't this break non-CE builds?