[webkit-reviews] review granted: [Bug 65246] [Qt][WK2] Clean WKPageLoaderClient : [Attachment 102124] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 65246: [Qt][WK2] Clean WKPageLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=65246

Attachment 102124: Patch
https://bugs.webkit.org/attachment.cgi?id=102124&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102124&action=review


r=me

> Source/WebKit2/UIProcess/qt/ClientImpl.cpp:116
> +    QUrl qUrl = urlStr;
> +    toQtWebPageProxy(clientInfo)->updateNavigationActions();
> +    toQtWebPageProxy(clientInfo)->didChangeUrl(qUrl);

I don't really see the need for the qUrl variable here.