[webkit-reviews] review denied: [Bug 65059] Add more testing to RenderLayer [ct'd] : [Attachment 101800] Proposed new test cases.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 27 00:04:22 PDT 2011


James Robinson <jamesr at chromium.org> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 65059: Add more testing to RenderLayer [ct'd]
https://bugs.webkit.org/show_bug.cgi?id=65059

Attachment 101800: Proposed new test cases.
https://bugs.webkit.org/attachment.cgi?id=101800&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
According to the checksums the chromium and mac versions of
absolute-position-change-containing-block-expected.png are identical, same for
absolute-position-moved-expected.png and
fixed-to-relative-position-with-absolute-child-expected.png.  would you mind
de-duplicating these and putting the shared .pngs next to the test?  I didn't
check all for dupes.

The comments in the tests seem a bit out of date - for example
nested-iframe-scroll-outer.html talks about a red box, but there isn't any such
box in the output (nor should there be red in the expectations for a pixel
test).


More information about the webkit-reviews mailing list