[webkit-reviews] review denied: [Bug 62684] Regression: font-size: 100% may cause ruby text to overlap : [Attachment 102092] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Kentaro Hara <haraken at google.com>'s request for
review:
Bug 62684: Regression: font-size: 100% may cause ruby text to overlap
https://bugs.webkit.org/show_bug.cgi?id=62684

Attachment 102092: Patch
https://bugs.webkit.org/attachment.cgi?id=102092&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=102092&action=review


This bug is about the overlap, but the patch changes other things. Most
notably, it allows greater overhang (more than half a ruby) in some cases. If
you want to change the maximum amount of overhang allowed, file a separate bug
and explain why you want to change that. The current implementation follows the
example in <http://www.w3.org/TR/2009/NOTE-jlreq-20090604/#en-subheading2_3_6>.


> Source/WebCore/rendering/RenderRubyRun.cpp:298
> +    int logicalLeftOverhang = 0;
> +    if (startRenderer && startRenderer->isText())
> +	   logicalLeftOverhang =
min<int>(toRenderText(startRenderer)->minLogicalWidth(),
startRenderer->style(firstLine)->fontSize()) / 2;
> +    int logicalRightOverhang = 0;
> +    if (endRenderer && endRenderer->isText())
> +	   logicalRightOverhang =
min<int>(toRenderText(endRenderer)->minLogicalWidth(),
endRenderer->style(firstLine)->fontSize()) / 2;

Why is it okay to set the logical left overhang based on the startRenderer
regardless of writing direction?