[webkit-reviews] review requested: [Bug 62852] cannot handle status codes which have no response body : [Attachment 102090] Add new FrameLoaderClient function to notify a case finished without response body.

[bugzilla-daemon at webkit.org]

Keunsoon Lee <keunsoon.lee at samsung.com> has asked  for review:
Bug 62852: cannot handle status codes which have no response body
https://bugs.webkit.org/show_bug.cgi?id=62852

Attachment 102090: Add new FrameLoaderClient function to notify a case finished
without response body.
https://bugs.webkit.org/attachment.cgi?id=102090&action=review

------- Additional Comments from Keunsoon Lee <keunsoon.lee at samsung.com>
Sorry for this late update.

Rough scenario for added flow is like follow;

1. DocumentLoader::finishedLoading() found m_gotFirstByte is false, which is
the target situation.
2. Notifying the situation to FrameLoaderClient through
dispatchDidFinishLoadingWithoutBody(), newly added function.
3. If FrameLoaderClient wants to show informational page, it should create
substitute data and send it to FrameLoader.
	3-1. If FrameLoaderClient does nothing for the function, FrameLoader
commits blank page.
4. FrameLoadTypeReload will be set for the substitute data for Back/Forward.
5. The original DocumentLoader will be stopped while loading the substitute
data.


There is a premise for this flow. 
PolicyUse should be selected for this.
That means, MIME Type from server or http stack (in case of content sniffing)
should be exist and a type for PolicyUse on FrameLoader.
I will consider to solve this after finishing this flow.

Finally, I'm not confident of the new function's name,
dispatchDidFinishLoadingWithoutBody.
It will notify to FrameLoaderClient that loading is finished but it has no
response body.
I feel this has similar meaning with dispatchDidFinishLoading(), so I chose the
name.
But, I'm not sure what different is dispatchDidFinishLoading from
dispatchDidFinishLoad.
I'd appreciate it if anyone can give me advice for this.

Any advice and comment will be welcome.

Thank you.