[webkit-reviews] review denied: [Bug 65218] Web Inspector: : [Attachment 102082] Add Web Inspector support for MAC MiniBrowser
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 26 17:41:37 PDT 2011
Mark Rowe (bdash) <mrowe at apple.com> has denied Genisim <genisim at yahoo.com>'s
request for review:
Bug 65218: Web Inspector:
https://bugs.webkit.org/show_bug.cgi?id=65218
Attachment 102082: Add Web Inspector support for MAC MiniBrowser
https://bugs.webkit.org/attachment.cgi?id=102082&action=review
------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=102082&action=review
> Tools/MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:390
> + GCC_PREPROCESSOR_DEFINITIONS =
"ENABLE_INSPECTOR=1";
Please do not set configuration settings in the Xcode project file. They live
in the .xcconfig file.
> Tools/MiniBrowser/mac/BrowserWindowController.m:255
> + {
This brace is in the wrong place.
More information about the webkit-reviews
mailing list