[webkit-reviews] review granted: [Bug 57042] Float32Array(ArrayBuffer, index, length) constructor working incorrectly. : [Attachment 102080] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Kenneth Russell
<kbr at google.com>'s request for review:
Bug 57042: Float32Array(ArrayBuffer, index, length) constructor working
incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=57042

Attachment 102080: Patch
https://bugs.webkit.org/attachment.cgi?id=102080&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102080&action=review


I think this is good, just have one question about signed-ness.

> Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:65
> +	   length = (buf->byteLength() - offset) / sizeof(ElementType);

What if offset is bigger than byteLength()?