[webkit-reviews] review denied: [Bug 64897] Minimum Row Height For PopupListBoxes should platform-dependent : [Attachment 101933] Updated according to fishd

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Fady Samuel
<fsamuel at chromium.org>'s request for review:
Bug 64897: Minimum Row Height For PopupListBoxes should platform-dependent
https://bugs.webkit.org/show_bug.cgi?id=64897

Attachment 101933: Updated according to fishd
https://bugs.webkit.org/attachment.cgi?id=101933&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101933&action=review


yeah, this is basically what i had in mind.  one more round.

> Source/WebKit/chromium/public/WebPopupMenu.h:44
> +    // Sets the minimum height of a popup listbox row.

nit: new line above this comment.

> Source/WebKit/chromium/public/WebPopupMenu.h:45
> +    WEBKIT_API static void setPopupListBoxMinimumRowHeight(int);

nit: no need to repeat the word Popup.	i'd probably just name this method
setMinimumRowHeight since it should be obvious that this could only refer to
the rows of the popup menu.