[webkit-reviews] review granted: [Bug 65044] [chromium] Layering violations in gesture recognizer : [Attachment 102044] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Robert Kroeger
<rjkroege at chromium.org>'s request for review:
Bug 65044: [chromium] Layering violations in gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=65044

Attachment 102044: Patch
https://bugs.webkit.org/attachment.cgi?id=102044&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102044&action=review


This looks great.  The comments below are only about whitespace.  :)

> Source/WebCore/platform/chromium/GestureRecognizerChromium.h:52
> +    typedef Vector<PlatformGestureEvent>*  Gestures;

Looks like you've got an extra space on this line.

> Source/WebKit/chromium/src/WebPopupMenuImpl.cpp:269
>      default:
>	   break;

I know this was here already, but the default case should be removed.

> Source/WebKit/chromium/src/WebPopupMenuImpl.h:150
> +
> +    

These lines are extraneous.

> Source/WebKit/chromium/src/WebViewImpl.cpp:776
> +	      
mainFrameImpl()->frame()->eventHandler()->handleGestureEvent(gestureEvents->at(
i));

Too much indent.