[webkit-reviews] review granted: [Bug 65004] [V8][Chromium] Run workers in a separate v8::Isolate : [Attachment 101685] Allocates v8::isolate per worker

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 26 13:23:41 PDT 2011


David Levin <levin at chromium.org> has granted  review:
Bug 65004: [V8][Chromium] Run workers in a separate v8::Isolate
https://bugs.webkit.org/show_bug.cgi?id=65004

Attachment 101685: Allocates v8::isolate per worker
https://bugs.webkit.org/attachment.cgi?id=101685&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101685&action=review


>> Source/WebCore/bindings/v8/V8Binding.h:120
>> +		m_DOMDataList.remove(m_DOMDataList.find(domDataStore));
> 
> What happens if domDataStore isn't in there?

Please add an assert here.


More information about the webkit-reviews mailing list