[webkit-reviews] review denied: [Bug 64365] TiledDrawingArea: Handle update requests in the order they were received. : [Attachment 100497] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 64365: TiledDrawingArea: Handle update requests in the order they were
received.
https://bugs.webkit.org/show_bug.cgi?id=64365

Attachment 100497: Patch
https://bugs.webkit.org/attachment.cgi?id=100497&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100497&action=review


Looks good, but let's clean it up a bit.

> Source/WebKit2/WebProcess/WebPage/TiledDrawingArea.cpp:181
> +    for (UpdateList::iterator it = m_pendingUpdates.begin(); it !=
m_pendingUpdates.end(); ++it) {

Keep the end() iterator in a separate variable for micro-optimization goodness.


> Source/WebKit2/WebProcess/WebPage/TiledDrawingArea.cpp:196
> +    for (UpdateList::iterator it = m_pendingUpdates.begin(); it !=
m_pendingUpdates.end(); ++it) {

Ditto.

> Source/WebKit2/WebProcess/WebPage/TiledDrawingArea.cpp:200
> +	       found = true;
> +	       break;

Simply return; here, and you won't even need the "found" variable.