[webkit-reviews] review granted: [Bug 62969] [WK2][Qt] Move from QGraphicsView to Qt Scene Graph : [Attachment 100808] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 62969: [WK2][Qt] Move from QGraphicsView to Qt Scene Graph
https://bugs.webkit.org/show_bug.cgi?id=62969

Attachment 100808: Patch
https://bugs.webkit.org/attachment.cgi?id=100808&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100808&action=review


r=me.

I must say the event delivery looks pretty disgusting, but there's not much we
can do about that here. :(
All in all, looks like a good place to start. Please consider Jocelyn's
comments before landing.

> Source/WebKit2/ChangeLog:14
> +	   QTouchWebView become a QSGItem with the only role of clipping
> +	   children items.

become -> becomes
children items -> child items

> Source/WebKit2/ChangeLog:17
> +	   QTouchWebPage become a QSGPaintedItem in order to render the content

> +	   of the flattened page. This is a temporary work around to get
> +	   something running withtout deep change on the drawing area proxy.

become -> becomes
withtout -> without
deep change -> deep changes