[webkit-reviews] review granted: [Bug 16734] Web Inspector: Better represent custom getters in the properties pane : [Attachment 101992] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 26 07:31:07 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 16734: Web Inspector: Better represent custom getters in the properties
pane
https://bugs.webkit.org/show_bug.cgi?id=16734

Attachment 101992: Patch
https://bugs.webkit.org/attachment.cgi?id=101992&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101992&action=review


Please revert unnecessary changes, otherwise looks good.

> Source/WebCore/inspector/InjectedScriptSource.js:203
> +		   property.name = propertyName + "";

Why is this concatenation needed?

> Source/WebCore/inspector/InjectedScriptSource.js:-196
> -		   property.value = this._wrapObject(value, objectGroupName);

What was the reason for changing this block? It should work without the change
and it was clear that exception could only be thrown in object[propertyName]


More information about the webkit-reviews mailing list