[webkit-reviews] review requested: [Bug 63531] Turn PreloadScanner implementation to a thread based solution : [Attachment 101999] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 26 07:24:39 PDT 2011


Balazs Kelemen <kbalazs at webkit.org> has asked  for review:
Bug 63531: Turn PreloadScanner implementation to a thread based solution
https://bugs.webkit.org/show_bug.cgi?id=63531

Attachment 101999: proposed patch
https://bugs.webkit.org/attachment.cgi?id=101999&action=review

------- Additional Comments from Balazs Kelemen <kbalazs at webkit.org>
Similar design than the last patch with the following improvements:
 * lots of refactoring
 * add a way to cancel pending tasks
 * schedule preloading on the main thread asyncronically through the event
system (via WTF::callOnMainThread)
   in order to be able to initiate the load as soon as possible and minimalize
the extra work that the parser
   need to do with preload scanning

It's still not fully ready since it's missing rebaselines for preload scanning
tests.
Benchmark results are on their way, be patient. Feedback is greatly welcomed.


More information about the webkit-reviews mailing list