[webkit-reviews] review canceled: [Bug 49142] Implement HTML5 style scoped attribute : [Attachment 97067] patch, HTML5 version, cleaned

[bugzilla-daemon at webkit.org]

Roland Steiner <rolandsteiner at chromium.org> has canceled Roland Steiner
<rolandsteiner at chromium.org>'s request for review:
Bug 49142: Implement HTML5 style scoped attribute
https://bugs.webkit.org/show_bug.cgi?id=49142

Attachment 97067: patch, HTML5 version, cleaned
https://bugs.webkit.org/attachment.cgi?id=97067&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at chromium.org>
Work-in-progress patch (only because some layout tests fail for unfathomable
reasons - most likely because of all the trees in front of the forest.)

Changes to previous patch:

-) As discussed on the ML, selectors are now scoped to the scoping element and
its descendants
-) Addressed Hixie's remarks

The new version is somewhat more complicated, because it has to interfere with
selector matching. Esp. RuleData grew by 4 bytes - I could not find an
efficient way to avoid this. @keyframe and @font-face are also not yet handled
- they are ignored for the time being (I would prefer to handle that in a
follow-up patch). :root and :scope are also not yet handled - those, too, would
be another patch for another bug(s).