[webkit-reviews] review requested: [Bug 63339] JSON errors should be informative : [Attachment 101968] patch (no speed regression this time)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 25 21:16:58 PDT 2011


Juan C. Montemayor <jmont at apple.com> has asked	for review:
Bug 63339: JSON errors should be informative
https://bugs.webkit.org/show_bug.cgi?id=63339

Attachment 101968: patch (no speed regression this time)
https://bugs.webkit.org/attachment.cgi?id=101968&action=review

------- Additional Comments from Juan C. Montemayor <jmont at apple.com>
This patch does not cause a speed regression in the sunspider tests. The cause
for the regression in the previous patch was the line that created an error
message for an unexpected identifier using String::format(). Removing the
String::format from that line will still create an adequate error message
(Unexpected identifier) and it will not cause a speed regression.


More information about the webkit-reviews mailing list