[webkit-reviews] review granted: [Bug 62478] RenderText::absoluteRectsForRange() and absoluteQuadsForRange() have nearly duplicate code : [Attachment 101949] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 25 17:32:59 PDT 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Emil A Eklund
<eae at chromium.org>'s request for review:
Bug 62478: RenderText::absoluteRectsForRange() and absoluteQuadsForRange() have
nearly duplicate code
https://bugs.webkit.org/show_bug.cgi?id=62478

Attachment 101949: Patch
https://bugs.webkit.org/attachment.cgi?id=101949&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101949&action=review


> Source/WebCore/rendering/RenderText.cpp:281
> +	       // change the height and y position because selectionRect uses
selection-specific values

Please change this to use sentence case and end with a period.

> Source/WebCore/rendering/RenderText.cpp:324
> +	       if (!rect.size().isZero())

Don't we have rect.isEmpty()?

> Source/WebCore/rendering/RenderText.cpp:405
> +	       if (!rect.size().isZero())

Ditto.


More information about the webkit-reviews mailing list