[webkit-reviews] review denied: [Bug 65037] [chromium] Accelerated drawing broken by mismatched compositor tile sizes : [Attachment 101747] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied David Reveman
<reveman at chromium.org>'s request for review:
Bug 65037: [chromium] Accelerated drawing broken by mismatched compositor tile
sizes
https://bugs.webkit.org/show_bug.cgi?id=65037

Attachment 101747: Patch
https://bugs.webkit.org/attachment.cgi?id=101747&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101747&action=review


> LayoutTests/platform/chromium/test_expectations.txt:3855
> +BUGWK65037 : compositing/color-matching/image-color-matching.html = IMAGE
> +BUGWK65037 : compositing/geometry/fixed-position.html = IMAGE
> +BUGWK65037 : compositing/geometry/vertical-scroll-composited.html = IMAGE
> +BUGWK65037 : compositing/overflow/fixed-position-ancestor-clip.html = IMAGE
> +BUGWK65037 : platform/chromium/compositing/huge-layer-rotated.html = IMAGE
> +BUGWK65037 : platform/chromium/compositing/tiny-layer-rotated.html = IMAGE

fyi: having these edits at the very end of test_expectations.txt means that you
will almost certainly get merge conflicts.  i'd suggest moving them up to a
random spot a few hundred lines off the end.  also, be careful that you don't
introduce any duplicates (run new-run-webkit-tests --lint-test-files to check)

> Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp:197
>  IntRect LayerTilerChromium::tileTexRect(const Tile* tile) const

this sure does look identical to tileLayerRect() to me, as enne noted. please
unify