[webkit-reviews] review granted: [Bug 64521] [EFL] Remove unused codes in ewk_tiled_model.c : [Attachment 100794] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 25 16:42:45 PDT 2011
Daniel Bates <dbates at webkit.org> has granted jungjik lee
<jungjik.lee at samsung.com>'s request for review:
Bug 64521: [EFL] Remove unused codes in ewk_tiled_model.c
https://bugs.webkit.org/show_bug.cgi?id=64521
Attachment 100794: proposed patch
https://bugs.webkit.org/attachment.cgi?id=100794&action=review
------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100794&action=review
OK to the changes. On another note, the first diff in this patch (i.e.
Source/WebKit/efl/ChangeLog) has a messed up chunk range of @@ -1,3 +1,15 @@.
It should be @@ -1,3 +1,18 @@. Hence patch(1) fails to apply this patch. Did
you edit the diff by hand?
> Source/WebKit/efl/ChangeLog:6
> + Reviewed by NOBODY (OOPS!).
> +
> + [EFL] Remove unused code in ewk_tile_model.c
> + https://bugs.webkit.org/show_bug.cgi?id=64521
Nit: We changed our changelog entry format such that a changelog entry should
have the bug title and URL then the Reviewed by line.
More information about the webkit-reviews
mailing list