[webkit-reviews] review granted: [Bug 65136] simplify the UI of the header above the test list table : [Attachment 101918] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 25 15:23:01 PDT 2011


Adam Barth <abarth at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 65136: simplify the UI of the header above the test list table
https://bugs.webkit.org/show_bug.cgi?id=65136

Attachment 101918: Patch
https://bugs.webkit.org/attachment.cgi?id=101918&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101918&action=review


> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:2346
> +    var isTrue = g_currentState[key];

isTrue ?

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:2347
> +    return '<label><input type=checkbox ' + (isTrue ? 'checked ' : '') +
'onclick="setQueryParameter(\'' + key + '\', ' + !isTrue + ')">' + text +
'</label>';

/me advertises jQuery.	:)


More information about the webkit-reviews mailing list