[webkit-reviews] review denied: [Bug 55046] Share VFP detection for ARM in MacroAssemblerARMCommon class : [Attachment 100891] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has denied Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 55046: Share VFP detection for ARM in MacroAssemblerARMCommon class
https://bugs.webkit.org/show_bug.cgi?id=55046

Attachment 100891: Patch
https://bugs.webkit.org/attachment.cgi?id=100891&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100891&action=review


Please fix Gabor's comments.
I also do think it would much more sense for this patch to change
MacroAssemblerARMv7's supportsFloatingPoint() method to call isVFPPresent(),
rather than just returning true.  Your patch is logically designed to affect
ARM & ARMv7, but is unnecessarily only being tested on ARM.  If you are not
going to use this on ARMv7, then then code should just remain in
MacroAssemblerARM.cpp.	If you are going to use it on ARMv7, then do so!

> Source/JavaScriptCore/assembler/MacroAssemblerARMCommon.cpp:67
> +{

Please move this to the header, we want this to be visible across all
compilation units.