[webkit-reviews] review granted: [Bug 65130] stop generating expectations.json now that it's unused : [Attachment 101901] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 25 13:39:09 PDT 2011


Adam Barth <abarth at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 65130: stop generating expectations.json now that it's unused
https://bugs.webkit.org/show_bug.cgi?id=65130

Attachment 101901: Patch
https://bugs.webkit.org/attachment.cgi?id=101901&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101901&action=review


R++

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:-782
> -	   return ExpectationsJsonEncoder(separators=(',', ':')).encode(
> -	       self._all_expectations)

Can we remove the whole ExpectationsJsonEncoder ?


More information about the webkit-reviews mailing list